Edward Moyse authored 5 years ago and Stewart Martin-Haugh committed 5 years ago

Initial commit of DumpEventDataToJSON, including Jets and TrackParticles, with some simple extrapolation.

Enable thread-safety static checker.
Fix a few issues with static data.

Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

EventInfo had some const methods that were returning non-const pointers
to member data.  This violates the spirit of const-correctness
(and the thread-safety checker warns about it).
Clean up by splitting the affected methods into const and non-const versions,
returning const and non-const pointers, respectively.

The following values were implicitly set by the BS converter of the legacy EventInfo:
MCChannelNumber(0), MCEventNumber(0), MCEventWeights(std::vector<float>(1,1));
Now they are set in the BS converted of the xAOD::EventInfo too.

Fixes ATR-19871

cppcheck warnings: use pre-increment rather than post-increment.

Remove EventInfoMCWeightFixAlg.  It's not actually referenced from anywhere,
uses the old EventInfo, and has const-correctness/MT issues.

Scott Snyder authored 5 years ago and Frank Winklmeier committed 5 years ago

Migrate xAODEventInfoCnvTool from using LuminosityTool to  LuminosityCondAlg.

Add a configuration fragment, xAODEventInfoCnvAlgDefault, which will set up
the luminosity conditions algorithm; it also disables running the algorithm
at BeginRun.

In passing, resolves ToolHandle constness issues.

These tests have been failing since we introduced ByteStream converter for xAOD::EventInfo

Truncate very small masses to zero in the output, to avoid some
rounding issues.

Given the new EventInfo is an xAOD object, it requires two converters: one for the interface
object and one for the Aux store. The names of new converters are:
	EventInfoByteStreamxAODCnv
	EventInfoByteStreamAuxCnv

Jack Cranshaw authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

GenericMetadataTool.

Protect against errors in legacy TC objects with the _v1 store
Add a throw on partial decoration data being read

     * TrigComposite (a.k.a. Decision) objects, when asked for an ElementLink, can now introspect if they've been decorated with re-mapped information.
     * Re-mapping of element links happens online at the end of processing, when EDM objects inside EventViews are copied out into EDM containers in the global event context.
     * Feature access code is reworked slightly to return LinkInfo objects rather than ElementLink objects. This is better as you can easily then also check which ROI your feature was in, etc.
     * The list of hard-coded chains was updated based on full_menu.py
     * HLTEDMCreator was updated to be given the HypoAlg output collection to remap rather than the InputMaker output. This was a bug before, features are attached by the hypo.
     * The way that `HLTEDMCreator` knows what collections need their element links updating was reworked - but reamins a bit clunky.
     * `HLTEDMCreator` indentation was standadised
     * Printing of feature properties was added to `TrigEDMChecker::dumpTDT`

Enable the thread-safety checker for most of the xAODTrig* packages and
apply the relevant fixes (mostly just `static` -> `static const`). The
following packages require less trivial fixes and still need to be done:

xAODTrigRingerAthenaPool
xAODTrigBphysAthenaPool
xAODTrigMuonAthenaPool
xAODTrigCaloAthenaPool
xAODTrigEgammaAthenaPool
xAODTriggerAthenaPool
xAODTrigger

Jack Cranshaw authored 5 years ago and Frank Winklmeier committed 5 years ago

- Change property 'SelectedStreams' to 'AcceptStreams' to mirror
FilteredAlgorithm interface.

Avoid adding duplicate services to SvcMgr.

Jack Cranshaw authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Move a log message to DEBUG level.

Tim Martin authored 5 years ago and Walter Lampl committed 5 years ago

Add extra type checking to TrigComposite. Allow casting to generic IParticleContainer interface. TODO add explicit check on cast