Update the tools NewtonTrkDistanceFinder and Trk2dDistanceSeeder
to be reentrant with const interfaces.

clang warnings:
 - Don't use std::move with a temporary.
 - Fix infinite recursion in iPatFitter::getMeasurements().
 

Assignment operator for ResidualPull cannot be defaulted because class
members are const.

clang warning: missing override keyword.

Christos Anastopoulos authored 5 years ago and Adam Edward Barton committed 5 years ago

binary_function deprecated / to be removed https://en.cppreference.com/w/cpp/utility/functional/binary_function

Susumu Oda authored 5 years ago and Adam Edward Barton committed 5 years ago

Original TrackSummary is copied if TrackSummaryTool is not found and TrackSummary is available. if-else style is unified in a part of the code.

Scott Snyder authored 5 years ago and Adam Edward Barton committed 5 years ago

Add const interfaces to IPRD_AssociationTool; instead of keeping
the tool state internally, these pass the state explicitly
as an additional argument.  The existing interfaces are retained
for now for backwards compatibility.

This is to allow fixing some violations of ToolHandle constness rules.

clang warnings: missing override keywords.