Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

EventInfo had some const methods that were returning non-const pointers
to member data.  This violates the spirit of const-correctness
(and the thread-safety checker warns about it).
Clean up by splitting the affected methods into const and non-const versions,
returning const and non-const pointers, respectively.

Also dropped presampler ConstLink typedefs and migrated all clients to the new interface.

Dropped HEC and FCAL ConstLink typedefs and the redundant FCALHVDescriptor class

Migrated following client packages to the new interface of HEC and FCAL components of LArHV:
  LArCalorimeter/LArGeoModel/LArReadoutGeometry
  LArCalorimeter/LArGeoModel/LArGeoAlgsNV
  LArCalorimeter/LArGeoModel/LArGeoH62004Algs
  LArCalorimeter/LArCondUtils
  LArCalorimeter/LArCafJobs
  LArCalorimeter/LArRecUtils
  LArCalorimeter/LArG4/LArG4FCAL
  LArCalorimeter/LArG4/LArG4HEC
  Calorimeter/CaloCondPhysAlgs
  graphics/VP1/VP1Systems/VP1CaloReadoutSystems

Riccardo Maria Bianchi authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

DD changes for VP1Light/DumpGeo

all the new packages to dump/write/load/handle the persistent copy of the GeoModel

changes in VP1 packages for VP1Light

changes in Event/xAOD packages for VP1Light, especially for Ubuntu compilation

new Project to build VP1Light

adding Doxygen docs

moving TFPersistification to the new standalone GeoGenericFunctions

excluding StoreGate code when building VP1Light

adding a stub implementation for the missing compare method

moving to the new standalone Eigen-based GeoModelKernel and GeoGenericFunctions

fixing compilation errors, missing ROOT libraries

moving GeoWrite to new standalone, Eigen-based GeoModelKernel

clever C++11 way to silence the 'unused parameter' warnings

moving the last pieces to the new, standalone, and Eigen-based GeoModelKernel

fixing compilation issues when building VP1Light

using ATLAS-wide 'release-detection' algorithm, instead of my own custom one

added ubuntu instructions

Update top menu

update top menu

Update README.md

Update README.md

fixing build errors and warnings

fixing find GeoModel

fixing perigee access outside vp1light

fixing TFPersistification warnings

fixing GeoModelExamples warnings

fixing VP1Gui warnings

fixing RunVP1Light warnings

fixing GeoExporter warnings

fixing VP1GeometrySystems warnings

fixing VP1AODSystems warnings

removing a test: random_shuffle() has been removed in C++17 and should be replaced

Fixing STANDALONE compilation of xAOD and Trigger packages

Fixing VP1Light compilation of VP1 packages

removing image files from repo

Adding copyright and updating macOS instructions

Cleaning code, adding copyright, and removing old packages

Replacing BUILDVP1LIGHT with XAOD_STANDALONE

Cleaning.

Removed custom reference counting, dropped ConstLinks for Electrodes and Modules and
migrated clients to the new interfaces. Documented memory ownership implemented by
HV Managers, Modules and Electrodes.

The `AlgErrorAuditor` is obsolete. Remove its usage and the relevant
reconstruction flag (`rec.abortOnErrorMessage`).

The goal of this reorganization is to drop the dependency of the LArHV
package on custom reference counting mechanism implemented by GeoModelKernel/RCBase.
The latter mechanism is thread-unsafe and it is not really needed for LArHV.

As a first step of this reorganization, only EMBHV* classes have been modified.
The EMBHV*ConstLink typedefs have been dropped and the package clients have been
migrated to the new interface.

This is just to demonstrate how VP1 packages should be updated to make them
a bit more easy to use in downstream projects. (Like WorkDir.)

The default Gaudi `Incident` class now provides the same features as the
ATLAS specific `EventIncident`, i.e. the access to the EventContext.

Some of the VP1 packages were using the ${QT5_ROOT} variable. Since that
variable no longer exists, it seemed reasonable to clean up the configuration
of these packages. While at it, I made all other cleanup that seemed reasonable.

All units migrated except GeoModelKernelUnits::gram/g, which is different from Gaudi::Units::gram/g

Files with identical content (same SHA1) but different file permissions
cause confusing differences shown in GitLab. The file permissions of
61 files were set to 644 (ATLINFR-2011).

Given the standalone library is based on Eigen instead of CLHEP, all GeoModel clients
in Athena code were also migrated to the Eigen-based interface of GeoModel. This affected
a large number of packages. Most significant changes have been introduced to subsystem
GeoModel packages.

The in-house GeoModelKernel code has been removed from the repository.

Almost all header files in PixelGeoModel have been moved to the src directory.
The next step should be turning this package into a component-only library.
Similar code reorganization can be applied to SCT_GeoModel too.

Subsystem readout geometry interfaces remain mostly unchanged, except for a minor
change in the InDet readout geometry interface (which was unavoidable).

Several non-GeoModel packages affected by this migration mostly required addition
of missing CLHEP includes.


Former-commit-id: 9cffebb1

Former-commit-id: ee9c11aa576db6df404cd42b6aec05be00dcaa1a

Catrin Bernius authored 6 years ago and Atlas Nightlybuild committed 6 years ago

Storing ED online setup changes

See merge request atlas/athena!15860

(cherry picked from commit 2d37f4b8 [formerly 79fd73179a63716f2005efe7d4386df5254b1c69])

5fb3a177 Storing ED online setup changes
f0736e22 Update EventUtils.py
b55a3e55 Update EventDisplaysConfig.py
e86e2e61 Update OnlineEventDisplaysSvc.py
a1d5ca40 Update PruneAlg.py
62d561dc Update ONCRPCServerSvc.cxx
1a16d917 Update ONCRPCServerSvc.cxx

Former-commit-id: 6b6fc89f

Former-commit-id: 1ab115dd

Former-commit-id: 9dc8a2c8628564d199dc0d9b3b7c0e74254fd8c7

gcc8 warning: Catching polymorphic exception by value.



Former-commit-id: c6cb057a

gcc8 warnings: Catching polymorphic exception by value.



Former-commit-id: 6913a0fe

Former-commit-id: d33bbc09

gcc8 warnings: Catching polymorphic exception by value.



Former-commit-id: 49d51d9b

Headers from CLIDSvc moved to AthenaKernel; adjust.
Remove unneeded direct dependency on SGTools.



Former-commit-id: c2e0a7c4

Former-commit-id: 3d2a36d5

Missing #include.



Former-commit-id: a3ec180e

Edward Moyse authored 6 years ago and Frank Winklmeier committed 6 years ago

Former-commit-id: 41349720

Susumu Oda authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Remove Lorentz angle related methods from SiDetectorElement. Remove SiLorentzAngleSvc and SiLorentzAngleCHSvc classes, their interface, and usages. (ATLASRECTS-4048, ATLASRECTS-4486)


Former-commit-id: e7d79d7c

Compilation warning: missing break in switch statement.



Former-commit-id: fcf31aa7