Skip to content

Resolve "TMRG crashing on is_enum_element method"

Andrea Paterno requested to merge 82-tmrg-crashing-on-is_enum_element-method into master

Description of the changes

Closes #82 (closed)

Changes VerilogElaborator's __is_enum_element method from private to protected (_is_enum_element) so that it is inherited by TMR. Changing every reference to this method name accordingly.

Changing management of the illegal, though widely supported, unpacked net declaration with assignment, such as:

logic b[5];
wire c[5] = b;

This syntax will now be supported for triplication, and a more descriptive warning thrown.

Check-list

  • Make sure that a changelog entry is present
  • Label the MR according to the content
  • If this MR has a dependency on another MR, specify the order in which the MRs should be merged
  • If the MR is done, please mark it as such by using the ~"Done - awaits merge" label, else mark it as "Draft: " by adding the prefix to the title
  • Designate a reviewer for this MR once done

Reviewer check-list

  • Make sure that the title describes the changes in the merge request
  • Make sure that the description of the changes is relevant and it describes all the changes
  • Make sure that the changelog entry is consistent with the changes. If the first release on top was released, then make sure that a new running release is created incrementing the minor index (the version is in the format major.minor.patch)
Edited by Szymon Kulis

Merge request reports