For trivial jobs without conditions (e.g. HelloWorld) do not try to
update COOL folders. This is necessary since COOL folder updates are now
configured by default (!42780).

Move the `enableCOOLFolderUpdates` configuration into the HLT framework
itself. COOL updates have become such an integral part of running the
HLT (e.g. HLT prescale updates) that this should be configured
centrally so it works also for non-`runHLT`-based jobs.

When running with concurrent chains multiple requests for the same ROB id can be
issued to the DCM for the same event slot. By locking the two ROB retrieval methods
the coherency of the internal ROB cache can be achieved. More explanations on ATR-19179.

Frank Winklmeier authored 4 years ago and Johannes Elmsheuser committed 4 years ago

Remove usage of obsolete `PACKAGE_VERSION` macro. Also cleanup
essentially empty methods.

Delete the following obsolete monitoring algorithms that have not been
used since a while and would first have to be migrated to athenaMT if
really needed:
 - TrigL1TopoWriteValData
 - TrigMuCTPiROBMonitor
 - TrigROBMonitor

Fix handling of unique_ptr.

Remove long-deprecated `chainList` and `sequenceList` interfaces from
`IIHLTConfigSvc`. Migrate all remaining code to use the
`chains/sequences` methods.

fix problem with invalid input (ES_WrongFileFormat) caused by
concatenating multiple filenames. athenaHLT.py parses input file
arguments with the 'append' option, so multiple '--file' options need to
be passed.

Our clang builds are currently building against the gcc tdaq builds and
there is not 'clang' platform tag in OKS. Simply revert to a (random)
existing tag to make the SW repository generation work. But this will
obviously not be usable in a partition.

Fixes ATR-22849.

Aleksandra Poreba authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

+ review changes

Remove unused link dependencies, move headers to src directory and
delete obsolete plotting script.

Add the `--loop-files` command line option. When set athenaHLT will loop
over the input files if the maximum number of events is larger than the
number of events in the input files(s). If no event count is given, it
will loop forever.

Also add a new options group for file I/O to make the help message look
a bit cleaner and fix arguments types for number of events.

Produce a "fast" stack trace by default in athena jobs. This initial
stacktrace will only report traces for the current thread but is much
faster than the full trace from gdb (which will follow). This can help in
cases when gdb does not manage to produce a stacktrace (e.g. due to
timeouts as in ATR-22583).

Aleksandra Poreba authored 4 years ago and Frank Winklmeier committed 4 years ago

Including whitespace changes, message formatting

- remove SCHEDULED (prefetched)
- rename DISABLED -> UNDEFINED

Also save robs status with unsigned short to avoid type
misinterpretation issues