Christos Anastopoulos authored 3 years ago and Frank Winklmeier committed 3 years ago

ATLASRECTS-6307 : Due to recent memory leaks. Vol.III (DiscSurface) of removing surface ctors with ptr

Delete unused `L1MenuCondAlg`, `HLTMenuCondAlg` and related python
configuration. These were early proto-types but the menu is now provided
by the config service as it does not change during the job.

Undefined shifts of signed integers.

Drop the `MT` suffix from the component names. Also rename the `hypo` to
`hypoAlg` to follow the usual naming convention.

Remove the code and scripts to generate the obsolete L1Topo XML files.
Also delete now unused `TriggerFlags.outputL1TopoConfigFile`.

The `L1TopoConfigSvc` is no longer needed for the Run-3 trigger. And
reading of the menu for Run-2 data during reconstructions is done via
a separate non-athena application.

Relates to ATR-23102.

`L1TopoConfigSvc` is no longer required in the Run-3 trigger. For
reconstruction of Run-2 data, separate code exists for the Run2to3 menu
conversion.

Package only contains one testing algorithm used during early L1Topo
developments.

Give an error if we try to deserialize something that's already in StoreGate
rather than using overwrite (except for TrigRoiDescriptorCollection).
Calling overwrite() is liable to corrupt ElementLinks.

See ATLASRECTS-6278 and ATEAM-734.

Change TrigNavStructure::m_rmutex to be a static member, as we can potentially 
have several instances of this class that we want to lock against each other.

See ATLASRECTS-6278 and ATEAM-734.

Skip deserializing a blob if we've already seen it.

See ATLASRECTS-6278 and ATEAM-734.

Ran Bi authored 3 years ago and Vakhtang Tsulaia committed 3 years ago

add bit mask definitions used in rel 21.0.

Ran Bi authored 3 years ago and Vakhtang Tsulaia committed 3 years ago

for 'ion' paths. same behaviour as in run 2.

Move the code to discover the `EDMVersion` flag in bytestream files to
`TrigEDMConfig.Utils` and cache the result for a given bytestream file.
This ensures we are only reading the file once. This is especially
important for mixed old/new job options where the flags are not being
locked and hence this function is called every time code reads the
`EDMVersion` flag.

Instead of using the address of the creator function use its fully
qualified name (including module) for the hash calculation. This will
make the caching reproducible and help debug problem seen in ATR-23347.

Also add unit test for `RecoFragmentsPool`.

We no longer support running the Run-2 trigger in release 22. Remove the
deprecated `run2Config` flag and set all derived flag values to their
defaults (corresponding to the '2017' value).

Aleksandra Poreba authored 3 years ago and Vakhtang Tsulaia committed 3 years ago

Update TrigCost hashes file path and change BunchCrossingCondData readhandle in EnhancedBiasWeighter

Reading the HLT trigger configuration is no longer supported in Run-3.
Delete the `readHLTconfigFromXML` flag and references to it.

Delete unused `TriggerFlags` and references to it:
 - doFEX
 - doHypo
 - doTrt
 - useCaloTTL
 - doBcm
 - doZdc
 - doLucid

Cleanup python configurables and remove setting of properties that no
longer exist in the C++ class.