Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

TBRec: Remove dependency on EventInfo.

Remove dependency on old EventInfo class.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

TBRec: Fix a const-correctness violation.
    
Should only get const pointers from a const AthenaHitsVector.

The `eformat_write` dependency is not needed as the bytestream
converters do not actually create the "writable" fragment. This is taken
care of by the ByteStreamCnvSvcBase.

Delete ancient code to monitor (pre Run-1) testbeam data.

Benjamin Morgan authored 3 years ago and Vakhtang Tsulaia committed 3 years ago

ATLASSIM-3150: Enable use of static Geant4 in Athena using "BigLibrary" pattern to improve simulation performance

Scott Snyder authored 3 years ago and Johannes Elmsheuser committed 3 years ago

TrkDetDescrAthenaPool+TBDetDescrAlg+TBDetDescrAthenaPool+MuonRPC_Cabling+MuonCablingServers: Enable thread-safety checking.

It is a widespread and reasonable, but incorrect, pattern to assume that if a handle(key) is not used then it should not be initialized.
In fact, this leaves the data dependency active in the scheduler, and no error will be thrown if the handle is never accessed.
Instead, the handle should be initialized(false) - this MR makes the change

Explicitly qualify virtual methods called from ctors.

    
Uninitialized pointer passed to SG::retrieve.

Christos Anastopoulos authored 3 years ago and Adam Edward Barton committed 3 years ago

IExtrapolator: interfaces methods returning unique_ptr rahter than plain. Makes clear the caller takes ownership

Unused variables.

Missing override keywords.

Switched several components in TBRec to reading CaloDetDescrManager from the
Condition Store. Part of the ongoing migration of all clients of the
CaloDetDescrManager

Migrate from IAtRndmGenSvc to IAthRNGSvc.

The code here is still flagrantly thread-unsafe, but not trying to fix
that now.

1. Switched TBCellContainerFillerTool to reading CaloDetDescrManager from
the Condition Store
2. Dropped the redundant dependency on CaloDetDescrManager from
TBClusterMaker, TBECLArRawChannelBuilder and TBEMECXTalkToyModel.
Instead they now retrieve CaloCell ID helpers directly from the
Detector Store

This is part of the ongoing migration of all clients of CaloDetDescrManager

    
Remove obsolete/unneeded references to LArRoI_Map.

Migrate from using the obsolete LArCablingLegacyService to conditions data.

Fix cppcheck warnings.

Use conditions data rather than the obsolete LArCablingLegacyService.

Fix cppcheck warnings.