Skip to content
Snippets Groups Projects
Xilin Wang's avatar
deleted branch Misalignment_Translation_and_Rotation at Xilin Wang / athena
Xilin Wang's avatar
deleted branch update_script_print at Xilin Wang / athena
Xilin Wang's avatar
pushed new branch update_script_print at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch Misalignment_Translation_and_Rotation at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch Misalignment_Translation_and_Rotation at Xilin Wang / athena
  • 0a5c8cb0 · Apply 1 suggestion(s) to 1 file(s)
Xilin Wang's avatar
deleted branch update_script_print at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch main at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch Misalignment_Translation_and_Rotation at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch main at Xilin Wang / athena
Xilin Wang's avatar
commented on commit 9c2eaaea "Add flags and Misalignment Modes" at Xilin Wang / athena

Hi Jakub, I think these are comments instead of 'discussions' so there's no option to mark them as resolved. Sorry.

Xilin Wang's avatar
pushed to branch update_script_print at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch update_script_print at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch update_script_print at Xilin Wang / athena
Xilin Wang's avatar
pushed to branch main at Xilin Wang / athena
Jakub Kremer's avatar
commented on commit 9c2eaaea "Add flags and Misalignment Modes" at Xilin Wang / athena

Hi @xilin, can you please resolve the threads that have been addressed by the additional commit? This helps to have a better overview for the review....

Xilin Wang's avatar
pushed to branch Misalignment_Translation_and_Rotation at Xilin Wang / athena
Xilin Wang's avatar
pushed new branch Misalignment_Translation_and_Rotation at Xilin Wang / athena
Xilin Wang's avatar
commented on commit 9c2eaaea "Add flags and Misalignment Modes" at Xilin Wang / athena

Hi @nstyles Thank you very much for the comments, I have just pushed a commit here ea90c165

Xilin Wang's avatar
pushed to branch update_script_print at Xilin Wang / athena
Nicholas Styles's avatar
commented on commit 9c2eaaea "Add flags and Misalignment Modes" at Xilin Wang / athena

We may want to make the "/Indet/AlignITk" configurable, so that this could also use the alignment folders for Run3, if running for that