TCT: Adding new tests: q445 and collisions test with latest data

Add missing required key:value pairs to /Digitization/Parameters metadata in CA-based configuration

See merge request atlas/athena!53626

John Derek Chapman authored 2 years ago and Julien Maurer committed 2 years ago

Now that flags.Digitization.DigiSteeringConf is auto-configured based on metadata, it can be used directly.

PanTauAlgs minor fixes

See merge request atlas/athena!53714

Bertrand Martin Dit Latour authored 2 years ago and Julien Maurer committed 2 years ago

PanTauAlgs minor fixes

Hello,

This MR is improving a few things: pass by reference instead of value, drop const_cast (the easy ones, there are still some to be removed), make code a bit more readable.
The reconstruction output is unchanged. Targets 22.0 as the goal is ultimately to make the corresponding algorithm re-entrant for Run3 reco.

Cheers,
Bertrand

r22 JetTagging: label_suspect_red

See merge request atlas/athena!53717

Alessandro Lapertosa authored 2 years ago and Julien Maurer committed 2 years ago

r22 JetTagging: label_suspect_red

tauRec: don't call tool finalize from within algorithm, and use smart pointers...

See merge request atlas/athena!53722

Bertrand Martin Dit Latour authored 2 years ago and Julien Maurer committed 2 years ago

tauRec: don't call tool finalize from within algorithm, and use smart pointers in PanTau to avoid delete in finalize

Hello,

With this MR, we no longer manually call the finalize method of tau tools from within tau algorithms, we let Athena do it (discussed in !50531 (comment 5338603), possibly relevant for ATLASRECTS-7047 too?).
Besides, now, we no longer do anything in tool finalize.
This is achieved by replacing raw pointers with smart pointers in PanTau.
We no longer use the MVAUtils BDT method that relies on a vector of float pointers, we use a vector of floats (possibly lighter for memory).
We no longer use variable caching to evaluate BDTs in PanTau, making one more step towards re-entrancy.
`PanTau::Tool_ModeDiscriminator::getResponse` can't be turned to `const` yet, but we're getting close...

The MR does not change the reconstruction output.

Cheers,
Bertrand

Minor fixes for HLTbphys T0 DQ web display config

See merge request atlas/athena!53723

Semen Turchikhin authored 2 years ago and Julien Maurer committed 2 years ago

Minor fixes for HLTbphys T0 DQ web display config

Update sTGC digitization to keep pad and wire charge

See merge request atlas/athena!53734

Chav Chhiv Chau authored 2 years ago and Julien Maurer committed 2 years ago

Update sTGC digitization to keep pad and wire charge

AthenaCommon: Don't pass exctrace preload to subprocesses.

See merge request atlas/athena!53730

Scott Snyder authored 2 years ago and Julien Maurer committed 2 years ago

AthenaCommon: Don't pass exctrace preload to subprocesses.

AthenaCommon: Don't pass exctrace preload to subprocesses.

Non-athena jobs may not work correctly with exctrace.
Remove it from the preload list for subprocesses.

See ATR-25610.

bugfix in eFexEMRoI Wstot calculation

See merge request atlas/athena!53719

Luke Baines authored 2 years ago and Sara Alderweireldt committed 2 years ago

bugfix in eFexEMRoI Wstot calculation

sTGC Strip Trigger:  Fixed the scattered point segment finding inefficiencies

See merge request atlas/athena!53292

Yi Yu authored 2 years ago and Sara Alderweireldt committed 2 years ago

sTGC Strip Trigger:  Fixed the scattered point segment finding inefficiencies

TriggerJobOpts: roll back to v5 global conditions tag in HLT for Run3 MC

See merge request atlas/athena!53735

Bertrand Martin Dit Latour authored 2 years ago and Sara Alderweireldt committed 2 years ago

TriggerJobOpts: roll back to v5 global conditions tag in HLT for Run3 MC

Hello,

This MR is temporarily changing the global conditions tag used by default in the HLT for Run3 MC, due to an incompatibility between MC21 RDO used in trigger ART tests and v6 MDT conditions (ATR-25570).
It would be great if this MR could be merged asap to avoid interferences with upcoming MRs changing trigger counts.

Cheers,
Bertrand

Cherry-pick  !5d1b2cdc from master: Add flag to OutputStream to write metadata and close after next Event.  ATEAM-832

See merge request atlas/athena!53689

Marcin Nowak authored 2 years ago and Julien Maurer committed 2 years ago

Cherry-pick  !5d1b2cdc from master: Add flag to OutputStream to write metadata and close after next Event.  ATEAM-832

Merge branch 'Sequencer.change.transition.SP' into 'master'

Add flag to OutputStream to write metadata and close after next Event. ATEAM-832

See merge request atlas/athena!53619

(cherry picked from commit b4fc1ea8)

5d1b2cdc Add flag to OutputStream to write metadata and close after next Event

HIMonitoring: enable thread-checker and package cleanup

See merge request atlas/athena!53684

Sweeping !53669 from master to 22.0.
AtlasBuildScripts: fix externals cleanup after build failure

See merge request atlas/athena!53702

Missing Muon collections from ESD/AOD, and other CA configuration fixes

See merge request atlas/athena!53710

Edward Moyse authored 2 years ago and Julien Maurer committed 2 years ago

Missing configuration and fix for doSegmentT0
Add missing MuonSegmentCnvAlg_NCB to MuonSegmentFindingCfg
AndDCMathSegmentMakerCfg: handle doSegmentT0 properly

Clean up Dev menu for early 2022 MC production

See merge request atlas/athena!53613

Francesco Giuli authored 2 years ago and Sara Alderweireldt committed 2 years ago

Clean up Dev menu for early 2022 MC production

Fill FwdEl EDM

See merge request atlas/athena!53706

Ulla Blumenschein authored 2 years ago and Sara Alderweireldt committed 2 years ago

Fill FwdEl EDM

BTaggingSV1Flip_forHL

See merge request atlas/athena!53627

Angela Maria Burger authored 2 years ago and Julien Maurer committed 2 years ago

BTaggingSV1Flip_forHL

TCT tests output comparisons: exclude leaves, fix art command with fixed reference

See merge request atlas/athena!53713

TCT tests output comparisons: exclude leaves, fix art command with fixed reference

fix AFP digitization setup with CA

See merge request atlas/athena!53716

Petr Balek authored 2 years ago and Julien Maurer committed 2 years ago

fix AFP digitization setup with CA

[TrigPartialEventBuilding] Protect configuration of RegionSelectorTools with detector flags

See merge request atlas/athena!53694

Rafal Bielski authored 2 years ago and Sara Alderweireldt committed 2 years ago

[TrigPartialEventBuilding] Protect configuration of RegionSelectorTools with detector flags