Marilena Bandieramonte authored 5 years ago and Walter Lampl committed 5 years ago

Fix thread-unsafety in Monopole code, G4mplEquationSetup class - Monopole MT  validation [ATLASSIM-4182]

G4mplEquationSetup class was implemented as a singleton, so it was not thread-safe. This affected MT simulation - with more than 1 thread:
the simulation was aborted for illegal values of energy, momentum and/or time.
Added the #ifdef G4MULTITHREADED directive to handle the multithreaded case. One instance of the class will be created per each thread
and stored in a tbb::concurrent_unordered_map that is hashed with the threadID number.

Scott Snyder authored 5 years ago and Walter Lampl committed 5 years ago

Currently, the calo detector description in CaloDetDescrManager first
gets created, with alignments applied subsequently.  In particular, this
implies that if one retrieves the detector description in initialize,
one will get it without alignments.  This is potentially confusing,
is bad for MT, and commonly leads to the tracking geometry being incorrectly
built without alignments.  Therefore, we are trying to move towards
building the detector description once, with alignments applied
at that point.  See ATR-19685 for further discussion.

This means that one should not retrieve CaloDetDescrManager during initialize().
Here, it was being used to initialize the call maps in BasicCellBuilderTool.
Modified so that this instead gets triggered via a callback after
the aligned calo det descr is created.

However, this exposes some additional points that warrant discussion.

The code here wants to deal with a grid of cells.  Whenever one is doing that,
it's important to consistently use the unaligned geometry; that is, what
one gets from the _raw() functions of the DDEs.  The code here wasn't
doing that.  However, because it was reading the detector description
during initialize(), before alignments were applied, what it was getting
was mostly the _raw() values --- though with an imporant exception.
Even in an unaligned geometry, there's a difference between eta() and eta_raw()
in the endcap, due to the 6cm shift of the cryostats from the original design.
The code now uses the _raw() functions to build the maps and hence consistently
does it in the calo cell coordinate system, but that's a difference from
what was done before, and hence results can change in the endcap.
I also adjusted the lookup in m_celllist_maps in
FastShowerCellBuilderTool::process_particle to adjust to the calorimeter
cell reference frame, but there are likely other places where there
are still inconsistencies.

testing is added

John Kenneth Anders authored 5 years ago and Atlas Nightlybuild committed 5 years ago

Add missing art-output declaration to test_athena_G4AtlasCosmic ART job

See merge request atlas/athena!23731

(cherry picked from commit 57955212)

ac5ce33f Add missing art-output declaration to test_athena_G4AtlasCosmic

John Kenneth Anders authored 5 years ago and Atlas Nightlybuild committed 5 years ago

Reduce memory need of TFCSParametrizationBase and all derived classes by 48 bytes

See merge request atlas/athena!23612

(cherry picked from commit cd0b182b)

908db882 Reduce memory need of TFCSParametrizationBase and all derived classes by 48 bytes

John Kenneth Anders authored 5 years ago and Atlas Nightlybuild committed 5 years ago

Fixes to RHadron simulation

See merge request atlas/athena!23714

(cherry picked from commit 7b0b7d9d)

adf48c06 Fixes to RHadron simulation

Import OutputStreamCfg in LAr.

Remove output for Overlay. Separate Basic config from config with output in Pixel, SCT and TRT. Fix default non-overlay name in BCM. Minor cleanup.

the StandardFieldSvc and ForwardFieldSvcCfg have been updated with the
other forward fields to be updated in a later commit.

Testing has been added

Using tree-orderer.py to sort the output.

Only run regression tests in SimCoreTests ART jobs in the case that the
original Athena job succeeded.

John Derek Chapman authored 5 years ago and Adam Edward Barton committed 5 years ago

Now `setupEventST` just calls `setupEvent` and `releaseEventST` just
calls `releaseEvent` in `BaseSimulatorTool`. This allows the syntax
of some derived classes to be simplified (`FastrasSimTool` and `TransportTool`)
and fixes a warning message about `ParticleKillerTool`.

Vakhtang Tsulaia authored 5 years ago and Adam Edward Barton committed 5 years ago

Modified EMBHVElectrode::hvLineNo() such that its reco clients now need to pass to it a pointer
to a LArHVIdMapping condition object, which provides mapping from electrodes to HV lines.

Migrated two clients of EMBHVElectrode - LArHVCondAlg and LArHVPathologyDbCondAlg - to the
new interface.

The AthSimulaton project was protected from the addition of new dependency on LArRecConditions
package, which hosts the LArHVIdMapping class, by leveraging the SIMULATIONBASE preprocessor statement

Remove (unused) references to ICaloSurfaceHelper.
We want to be removing it.

Only run regression tests in ISF_Validation ART jobs in the case that the
original Athena job succeeded.

Scott Snyder authored 5 years ago and Adam Edward Barton committed 5 years ago

Add const interfaces to IPRD_AssociationTool; instead of keeping
the tool state internally, these pass the state explicitly
as an additional argument.  The existing interfaces are retained
for now for backwards compatibility.

This is to allow fixing some violations of ToolHandle constness rules.

After !22621 then all `PileUpTools` are private to the instance of
`PileUpToolsAlg` or `DigitizationAlg`, so the syntax in
`NightlyPileUp.py` needs to be updated accordingly. This should fix
ATLASSIM-4179.

Progress on turning includes into functions.

Continue adaptation.

Add flags towards working test. Improve descriptions of LAr Digitization flags.

Fill in missing flags. Functions now execute.

Continue progress towards working project

Give migrated JobOptions scripts nicer names. Fix migration errors. Add ItemList.

Move some variables out of flags.

Move joboptions include replacements to new locations.

Fix neglected imports, remove redundant imports.

Move flags to appropriate locations. Remove reco flags for digitization only config. Add __init__ file for CaloConditionsConfig. Add tag option to LArBadChannelConfig functions.

Fix sim flag name. Add missing LArBadFedCondAlg import. Remove redundant todo comments