Skip to content

dSiPM: decoding updates

Stephan Lachnit requested to merge slachnit/peary:dsipm_tb3 into master

/cc @simonspa @ffeindt @tvanat

This is the latest branch we used dSiPM decoding. Based on !135 (merged).

  • Adds structured view of the timestamp bits to the README
  • Fixes a TODO from dSiPMFrameDecoder.cpp, namely adding the second bit flag to the decodeTrailer() function. Since using a tuple with this many variables seems a bit of a mess to me, I added a struct. EUDAQ2 merge request coming soon.
  • In dSiPMFrameDecoder.hpp I added changed a line to ensure bools are decoded properly by explicitly casting to bool via int_val != 0. In practice it doesn't change anything since the compiler already does this, but I found it more readable.
  • In dSiPMFrameDecoder.hpp I changed some of the hex constants to bit constants instead, since it's easier to understand when you look at the timestamp bits (now found in the README).

Merge request reports