Apply 3 suggestion(s) to 3 file(s)

GeoModelCore/GeoModelKernel/GeoModelKernel/GeoAlignableTransform.h

@@ -39,8 +39,6 @@ class GeoAlignableTransform final : public GeoTransform
   virtual ~GeoAlignableTransform() = default;
 
  private:
-  GeoAlignableTransform(const GeoAlignableTransform &right);
-  GeoAlignableTransform & operator=(const GeoAlignableTransform &right);
 
   // Pointer to an alignment correction.  Until some
   // alignment correction is set, this pointer is nullptr and

GeoModelCore/GeoModelKernel/GeoModelKernel/GeoTransform.h

@@ -23,8 +23,6 @@ class GeoTransform : public GeoGraphNode {
  public:
     GeoTransform(const GeoTrf::Transform3D& transform);
 
-    GeoTransform(const GeoTransform &right) = delete;
-    GeoTransform & operator=(const GeoTransform &right) = delete;
 
   /// Gets the total transformation.
   virtual GeoTrf::Transform3D getTransform(const GeoVAlignmentStore* store=nullptr) const;

GeoModelCore/GeoModelKernel/src/GeoAlignableTransform.cxx

@@ -68,7 +68,7 @@ void GeoAlignableTransform::clearDelta(GeoVAlignmentStore* store) {
   
   std::set<GeoGraphNode*> uniqueParents;
   for(GeoGraphNode* parent : m_parentList) {
-    if(!uniqueParents.insert(parent).second) {
+    if(uniqueParents.insert(parent).second) {
         GeoSelClearAbsPosAction cc(this);
         parent->exec(&cc);
     }

[Joseph Boudreau]

It seems like some logic was inverted in GeoAlignableTransform. Why? Did you introduce and then fix some faulty code?

[Johannes Junggeburth]

The old code was checking that the element is not in the uniqueParents list

if(uniqueParents.find(parent)==uniqueParents.end()) {

while in the new version I accidentially, put first

 if(!uniqueParents.insert(parent).second) {

which is a invert of the logic. Indeed, I fixed a logical typo.