-
- Downloads
There was an error fetching the commit references. Please try again later.
Make GeoFacet a protected detail of GeoPolyhedron
Compiling GeoModel with LTO enabled identified a One Definition Rule warning: ``` [100%] Linking CXX shared library libGeoModelKernel.so .../GeoModel.git/GeoModelCore/GeoModelKernel/GeoModelKernel/GeoFacet.h:24:7: warning: type 'struct GeoFacet' violates the C++ One Definition Rule [-Wodr] 24 | class GeoFacet : public RCBase | ^ .../GeoModel.git/GeoModelCore/GeoModelKernel/GeoModelKernel/GeoPolyhedron.h:168:7: note: a type with different bases is defined in another translation unit 168 | class GeoFacet | ^ [100%] Built target GeoModelKernel ``` Following discussion in #77, resolve this by making `GeoFacet` in `GeoPolyhedron.h` a protected implementation detail of `GeoPolyhedron`. Update friendship operators and use elsewhere for nesting.
parent
96396bed
No related branches found
No related tags found
Showing
- GeoModelCore/GeoModelKernel/GeoModelKernel/GeoPolyhedron.h 28 additions, 27 deletionsGeoModelCore/GeoModelKernel/GeoModelKernel/GeoPolyhedron.h
- GeoModelCore/GeoModelKernel/src/BooleanProcessor.src 1 addition, 1 deletionGeoModelCore/GeoModelKernel/src/BooleanProcessor.src
- GeoModelCore/GeoModelKernel/src/GeoPolyhedron.cxx 1 addition, 1 deletionGeoModelCore/GeoModelKernel/src/GeoPolyhedron.cxx
Loading
Please register or sign in to comment