Fix duplicate volumes when reading a .db back in

When restoring the GeoModel tree from a .db file, a larger number of PhysVols than expected were found.

The problem turned out to be in GeoModelRead, in the caching of the volumes that were built.

The copyNumber was used to create a cache key, together with tableID and volumeID.

But the string tableID-volID-copyN was identifying each volume uniquely... so, when restoring the GeoModel tree from a file, all volumes that should be built as "shared" were created, instead, as unique instances.

I fixed that by removing the copyNumber from the key used for the cache. In that way, all volumes with the same tableID and volID, but with different copyNumber, share the same Volume instance.

GeoModelExamples/HelloGeoRead/main.cpp

-// Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+// Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 
 /*
  * HelloGeo.cpp
@@ -66,25 +66,35 @@ GeoPhysVol* createTheWorld(GeoPhysVol* world)
 
 int main(int argc, char *argv[])
 {
-  // QCoreApplication app(argc, argv);
 
-  // GET GEOMETRY FROM LOCAL DB
-  // Set valid db path before first run
-  const std::string path = "geometry.db";
-  std::cout << "Using this DB file:" << path << std::endl;
+    if(argc != 2)
+    {
+        fprintf(stderr, "\nERROR!\nusage: %s input.db\n\n", argv[0]);
+        return 1;
+    }
+    // Get the input SQLite '.db' file containing the geometry
+    std::string line;
+    std::string fileName;
+    fileName = argv[1];
+    std::cout << "Using this SQLite '.db' file:" << fileName << std::endl;
+
 
   // check if DB file exists. If not, return.
   // FIXME: TODO: this check should go in the 'GMDBManager' constructor.
-  std::ifstream infile(path.c_str());
+  std::ifstream infile(fileName.c_str());
     if ( ! infile.good() ) {
-      std::cout << "\n\tERROR!! A '" << path << "' file does not exist!! Please, check the path of the input file before running this program. Exiting...";
+      std::cout << "\n\tERROR!! A '" << fileName << "' file does not exist!! Please, check the path of the input file before running this program. Exiting...";
       exit(EXIT_FAILURE);
   }
   infile.close();
+  
+
+  // GET GEOMETRY FROM LOCAL DB
+
 
 
   // open the DB
-  GMDBManager* db = new GMDBManager(path);
+  GMDBManager* db = new GMDBManager(fileName);
   /* Open database */
   if (db->checkIsDBOpen()) {
     std::cout << "OK! Database is open!\n";