Allow GeoModelXml envelopes to be GeoFullPhysVol as well as GeoPhysVol
When investigating the possibility to use the existing GeoModelXml "Envelope" mechanism to insert new service material inside an existing volume (in this case to position ITk/HGTD service material in the Calorimeter crack region) it was noticed that the mechanism only works for GeoPhysVols while the specific location where new items would ideally be inserted is a GeoFullPhysVol. This MR adds the capability to also use a GeoFullPhysVol as an Envelope.
The latter does not inherit from the former, nor do they share a common base class with a virtual add method, and so we need to treat each case separately rather than a more simple solution that could support both through polymorphism. That being said, there could well be a better way to do this than what I've implemented here.
FYI @mbandier @dellacqu in case you have comments or suggestions.
Merge request reports
Activity
Hi - I was just wondering if there are any standard tests I should do before this could be considered for merging? I've been trying to do some Athena-based tests, but since this requires recompiling all the externals it is not proving very straightforward.
This development is needed for our current plans of how to implement ITk and HGTD service material within the Calo volume.
Hi @nstyles ,
Thanks for this MR! I had a look at it and in principle it looks fine to me, but @dellacqu should be the one commenting here. Also, we will probably discuss this MR the coming Monday at the DD meeting (in case you wish to attend), so that we can proceed with the merging as soon as possible.
Cheers, Marilena
-
Hi @mbandier - thanks for the response. Unfortunately I have another meeting I have to join on Monday afternoon so I won't be able to join the Detector Description meeting, but I will follow up afterwards in case there are suggestions/questions/tests I should do.
mentioned in merge request !143 (merged)