FSL phys list plugin interface

The FSL tool gives a possibility to choose the physics list which is better for simulation by specifying the physics list name, but in some cases, there is a need to make a custom physics list.

The interface of connecting the custom physics list has been done in a similar way as a connecting of the user action plugin. For this, the new class FSLPhysListFactory was developed which can work with the physics list name, or with the physics list plugin.

After changes, the plugin can be connected through FSL as shown below in the picture, and backward compatibility is saved.

The plugin code used for the testing is attached to the description. TestPhysicsListPlugin.cc

added FullSimLight label

assigned to @dklekots

requested review from @mbandier and @dellacqu

changed the description

assigned to @mbandier

unassigned @dklekots

Dear @dklekots ,

Many thanks for this merge request! I had a look at it and it looks OK to me. I guess you also created a plugin with your custom physics list. Could you please make it available somewhere so that I could test it before proceeding with the MR? Thanks.

Cheers, Marilena

Dear @mbandier,

The test plugin code can be found in the repository https://gitlab.cern.ch/dklekots/denys-klekots-summer-student-project/-/tree/master/FSLTestPhysListPlugins, and also TestPhysicsListPlugin.cc file attached to the description of the merge request.

During working on this plugin I widely used examples on the GeoModelATLAS repository. If you find this example to be proper, may I ask you to add it to the GeoModelATLAS repository, or alternatively give me an admission to create a merge request?

With best regards Denys.

unfortunately the GeoModelATLAS repository is not under our control, I can't give you access nor can Marilena, as far as I can see...

andrea

Ok, that is not a problem, I just meant that it will be good to post it somewhere as an example (in case you like it).

Hi @dklekots,

Many thanks for sending the link to your repository, I am going to test it now. For what concerns the GeoModelATLAS repository, we could ask the administrators to give you access, that's not a problem. However, since we are planning to move out the "general plugins" from the GeoModelATLAS repository and put them under a new folder of FullSimLight, I believe that that should be the place for your plugin. In fact, being an experiment independent plugin, it should belong to the FullSimLight example plugins/extensions folder (for example together with the sensitive detectors plugin, the hits creation plugin and the dummy user actions plugins). @dklekots and @dellacqu what's your opinion about that?

Cheers, Marilena

Hi again, I just tested the plugin and it works fine to me. The only thing I'd ask is to change the FSL GUI so that it's possible to browse to the location of the plugin (as in the case of the Geometry) or to specify manually the Physics List name. Maybe we could also put all the available physics lists names under a QComboBox (as it is done for the list of particles under the Generator tab. Would that be possible?

Many thanks, Marilena

Dear @mbandier,

From my side, it is good to change GUI, but to say truly, I have not much experience with Qt, so it takes a longer time (but I am not giving up do that).

Concerning the plugin example, from my side, it is good to place the plugin under the FullSimLight example plugins/extensions folder.

With best wishes Denys.

Dear @dklekots,

I see, thanks! I think there's no problem on our side to wait a bit for it (if it's in the order of one or 2 weeks). We could also just merge the code now and then adjust later the GUI (FYI @raees is the main developer of the FSL GUI). It depends on what's the priority for your project now (so I let you and @dellacqu discuss about that!).

Cheers, Marilena

Dear @mbandier , @dklekots

I can make the changes on the FSL GUI to have a dropdown menu of available physics lists as well as the option to choose a plugin.

Best, Raees

Thank you @raees ! OK, that's fine by me if @dellacqu and @dklekots agree. Waiting for your OK to merge this.

Cheers, Marilena

Dear all, sorry for no reply from my side. It's Ok for me if you merge this branch now.

Dear @raees, thank you!

With best wishes Denys.

OK, perfect @dklekots. Thank you and best wishes to you!

approved this merge request

merged