Removed printouts from GeoModelKernel/GeoVolumeTagCatalog.h
Merge request reports
Activity
mentioned in commit 99e83265
Hi @tsulaia - I wonder if this should also be added in the
master
branch, as otherwise we will have the same unit-test failures as today as soon as we move to a newer version (which for Upgrade developments we'd like to do pretty soon)? Or do you think there might be another better solution for the logging that might be available soon?Hi Nick, What I did here was a quickest possible patch to fix the failing unit tests in the master.
As for the "proper" solution, I'm not the author of
GeoVolumeTagCatalog
, so I don't think I'm the right person to decide how we should be dealing with these printouts in the long run. I was going to bring this topic up for discussion in the next (bi-)weekly DD group meeting which takes place on Mondays at 17:00 CERN. If this is becoming urgent, and we cannot wait until Monday, then I can also start an email thread about it.I think it might be good to have a more general discussion about log message handling. At the moment, there is a lot of information dumped to the logs which is useful for debugging but really bloats the logs for normal use. For example this was discussed here:
and if you look here, you can see the max log size gets exhausted just through GeoModel messages:
(I think in this case it is perhaps because the build is done with debug symbols, so this is a bit closer to the desired behaviour if so?)
It would be great if there was some way to have a bit more control over this.
mentioned in merge request !153 (merged)