Decoupling FullSimLight from FSL. Closes #80

This MR decouples the build of FullSimlIght from the build of FSL.

With this MR, when building FullSimLight, FSL is not build.

It closes #80 (closed)

added CMake configuration FSL GUI FullSimLight labels

Many thanks @rbianchi for this MR! Cheers, Marilena

merged

mentioned in commit fece4eda

Hi @rbianchi,

After updating to the current master I have a problem running cmake:

cd geomodel/build

cmake $HOME/geomodel/GeoModel \
-DGEOMODEL_BUILD_ALL=1 \
-DGEOMODEL_BUILD_EXAMPLES=1 \
-DCMAKE_PREFIX_PATH=/opt/homebrew/opt/qt5 \
-DCMAKE_INSTALL_PREFIX=$HOME/geomodel/install

This fails with the following message:

CMake Error at CMakeLists.txt:98 (add_subdirectory):
  The binary directory

    /Users/evc/geomodel/build/FullSimLight

  is already used to build a source directory.  It cannot be used to build
  source directory

    /Users/evc/geomodel/GeoModel/FullSimLight

  Specify a unique binary directory name.

Could you have a look,

Evgueni

Hi @evc , I see the problem, basically the FullSimLight directory is included twice with the 2 flags GEOMODEL_BUILD_FULLSIMLIGHT and GEOMODEL_BUILD_FSL. Instead a check should be done on the flags to include it only once. it should be fairly straightforward but we can discuss it today at our meeting. Cheers

Hi @evc ,

Good catch! Thanks for reporting this, Evgueni.

The problem was that when selecting GEOMODEL_BUILD_ALL, both GEOMODEL_BUILD_FSL and GEOMODEL_BUILD_FULLSIMLIGHT were set to TRUE, and both included the FullSimLight subdirectory, which triggered the error message.

I fixed it in master with commit 8d8bd8b0, and I tried it on my Mac.

Could you try and confirm that it works for you too?

Thanks, --Ric.

Hi @rbianchi,

Yes, it works. -- Evgueni

Also, @mbandier spotted another error when both BUILD_FSL and BUILD_FULLSIMLIGHT were enabled.

So, I just fixed that by adding a check in our CMake configuration and setting the BUILD_FULLSIMLIGHT option to FALSE when the user enables both.

I also inform the user with a note from CMake:

I pushed that to master with commit 840a90ae

Best, --Ric.