Skip to content
Snippets Groups Projects

Fix the compilation of I/O helpers

Merged Riccardo Maria Bianchi requested to merge fix-io-helpers into main
All threads resolved!

This MR fixes a few compilation issues caused by the recent migration of the "World" volume from GeoPhysVol to a more general GeoVPhysVol.

Related to !213 (merged) and #62 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sarka Todorova mentioned in merge request !211 (merged)

    mentioned in merge request !211 (merged)

  • added 3 commits

    • 6f1e9238 - Change behavior of I/O helper functions, add a new 'getReader'helper.
    • 14db7f62 - Update the HelloGeoRead example with the use of the new I/O helpers.
    • 0dce221f - removing the old example

    Compare with previous version

  • I have updated loadDB. Also, I added a const to that and to buildGeoModel. You are right, we could and should have const on the public loader methods.

    I then remove the constness in visualization only.

    Now working on the saveDB.

    Edited by Riccardo Maria Bianchi
  • added 1 commit

    • 2a0bfc75 - Add constness to methods loading .db and returning 'world'.

    Compare with previous version

  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • added 1 commit

    • 53a44dae - Fixed compilation of Tools, Examples and FullSimLight

    Compare with previous version

  • Vakhtang Tsulaia mentioned in commit f2392d69

    mentioned in commit f2392d69

  • mentioned in issue #96 (closed)

  • Riccardo Maria Bianchi mentioned in merge request !219 (merged)

    mentioned in merge request !219 (merged)

  • Please register or sign in to reply
    Loading