GeoModelShape - Use GeoIntrusivePtr, inline clean ups

• Use GeoIntrusivePtr for GeoShapeUnion, GeoShapeShift, etc.
• Change const double& to double signature
• change mutable double fVolume to std::atomic fVolume.

• GeoShapeInterSection.h

added 1 commit

• f27681f1 - More stuff to update

Compare with previous version

Given these are rather critical changes, can we perhaps make sure that we cleanly break down these changes into individual commits? For example, the comment for 5829c0da says "Use GeoIntrusivePtr" but the commit does way more than this: formatting changes, proper initialization of data members, making various constructor overloads as delete, etc. These are all good changes, but I think they should be implemented either in separate commits, or in separate MR-s.

Personally, I would avoid trying to make this migration in one giant MR but rather do it in stages, if possible.

Thanks.

Sure this MR can be broken up into smaller parts:

• GeoPhysVol
• GeoShapes
• GeoLogVol

etc.

added 8 commits

• f27681f1...818df80e - 5 commits from branch main
• 2b021b79 - Use GeoIntrusivePtr
• d42c7546 - Include RCBase
• 2c3e7ee1 - More stuff to update

Compare with previous version

added 1 commit

• 28189ac1 - Fix compiler

Compare with previous version

changed title from Draft: Use GeoIntrusivePtr to Draft: Use GeoIntrusivePtr -- Do not merge

added 21 commits

• 28189ac1...3a7e347c - 20 commits from branch main
• f5c312b9 - Merge branch 'main' into 'GeoSmartLinkUse'

Compare with previous version

added 6 commits

• f5c312b9...661778e1 - 5 commits from branch main
• 880ddb09 - GeoShape - Use Intrusive ptr. Clean up inline

Compare with previous version

marked this merge request as ready

changed title from Draft: Use GeoIntrusivePtr -- Do not merge to GeoModelShape - Use GeoIntrusivePtr, inline clean ups

changed the description

added 1 commit

• 01d9f70d - Migrate remaining shapes

Compare with previous version

Looks good to me. Tested by building GeoModelATLAS on top of it and running some gmcat tests.

See #99 for the discussion about the issues with mac pipelines

mentioned in commit 6011e5b7

merged