Skip to content
Snippets Groups Projects

GeoShapeShift - Collapse a chain of GeoShapeShifts into one

Merged GeoShapeShift - Collapse a chain of GeoShapeShifts into one
collapseShift into main
All threads resolved!
Merged Johannes Junggeburth requested to merge collapseShift into main
All threads resolved!

I've seen in the muon geometry a couple of places where we have

GeoShapeShift ( GeoShapeShift (GeoShapeShift (GeoShapeShift of something

That's producing an unneccassry call twoer given that we're only interested in the summarized shift. This little checks at the construction stage of the GeoShapeShift whether the given shape is another shift. If so, then it combines the two transformations and takes the operand of the child.

Tagging: @rbianchi, @boudreau, @tsulaia

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 0378b870 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Vakhtang Tsulaia
    Vakhtang Tsulaia @tsulaia
    Owner

    Looks good! Thanks

  • Johannes Junggeburth merged

    merged

  • Johannes Junggeburth mentioned in commit 5262cef7

    mentioned in commit 5262cef7

    • Please register or sign in to reply