Skip to content
Snippets Groups Projects

Make alignable multicopies work without loopvar

Merged Nicholas Styles requested to merge nstyles/GeoModel:AlignFix2 into main
All threads resolved!

Attempt to solve the issue mentioned in !306 (merged)

The behavior of multicopy when a loopvar is not used does not seem correct regarding alignment. Following up with the original author

Possible an equivalent fix is also needed for the various Replica processors.

FYI @xilin @sroe

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicholas Styles added 1 commit

    added 1 commit

    Compare with previous version

  • Nicholas Styles added 1 commit

    added 1 commit

    • bcf11c15 - Revert "dynamic->static casts"

    Compare with previous version

  • Hi @nstyles, the pipeline looks better now, with the build_geomodel_athena failing as expected.

    @jojungge said he might be able to find a quick fix for this problem. If not, then perhaps we can take our chances and merge this one tomorrow. Then make 5.4.0 and switch Athena to it.

  • Nobody objected so far. I'll go ahead and merge it. If everything goes well with the after-merge pipeline then I will cut 5.4.0

  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • Vakhtang Tsulaia mentioned in commit 9fd18a6d

    mentioned in commit 9fd18a6d

  • Please register or sign in to reply
    Loading