Deal with mutable materials such as a gas mixture.

To deal with mutable materials such as a gas mixture, the GeoLogVol now has a method to update the material

@jojungge MR is created, can you please add the protections you were recommending?

added 1 commit

• b3360a46 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• 5968d14a - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• 607779b9 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

resolved all threads

added 1 commit

• cb0da76c - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

enabled an automatic merge when the pipeline for cb0da76c succeeds

aborted the automatic merge because source branch was updated

added 1 commit

• 4115c6b6 - fix compilation error

Compare with previous version

added 1 commit

• 87decf42 - TEST the ATHENA pipeline without mutex in the modified GeoLogVol

Compare with previous version

The athena pipelines fails when the FCAL construction downcasts a pointer, here:

https://gitlab.cern.ch/atlas/athena/-/blob/main/LArCalorimeter/LArGeoModel/LArReadoutGeometry/src/FCALModule.cxx?ref_type=heads#L34

So I this latest commit is just a test, to see whether the issue is coming from the mutex or from the new setMaterial method. When understood we can hopefully find a solution.

In the meantime, the FCALModule on the Athena side should be updated to remove this downcasting.

marked this merge request as draft

added 1 commit

• 87118012 - Add back the header file inclusion and retest

Compare with previous version

added 1 commit

• c697380d - Add back mutex member data

Compare with previous version

The down cast shouldn't be the problem. It's probably the changed memory layout of the class and that somehow the athena integration pipeline broke.

I think so too. But, from the log file I cannot see where it would pickup up the old, unmodified header file from, the include directives all seem correct to me. I was going to test the downcasting locally anyway, though I agree it's probably futile.

added 1 commit

• 739a1722 - Reactivated the mutex locking and switched on verbose flag during athena build

Compare with previous version

added 1 commit

• ebc03cf5 - Turn off verbosity in athena build, I learned nothing. Print a message from...

Compare with previous version

From the last run of the pipeline I did indeed, I did Indeed learn something useful. On account of the extra debugging information I learned that some pieces of Athena were picking up one version of geomodel header files, others were picking up a different version. Notably the code in LarGeoBarrel picked up the correct version, which is the one under test. On the other hand, LArReadoutgeometry did not. There is a clear difference in the cmakelist for these two packages. And I believe that Larreadoutgeometry is defective and needs to explicitly point to the geomodel include directories. This type of problem could be widespread. @jojungge @tsulaia does that seem reasonable?

added 1 commit

• c46cbacf - Remove compilation message which was only for debugging.

Compare with previous version

resolved all threads

marked this merge request as ready

mentioned in commit 3ca946cb

merged