Skip to content
Snippets Groups Projects

Header Relocatability, main branch (2024.06.27.)

As I had to discover in atlas/atlasexternals!1136 (merged), !326 (merged) did not manage to fix everything for the https://gitlab.cern.ch/GeoModelDev/GeoModel/-/tags/6.0.0 tag. :frowning: !327 (merged) introduced a new package, GeoModelCppHelpers, which didn't follow the changes that I made in !326 (merged). :frowning2:

Generally, the CMake configuration of the project should be cleaned up a bit. :thinking: Since right now one can make such mistakes in just too many places. Unfortunately I can't really volunteer to do this. At least not any time soon. :frowning:

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @akraszna, GitLab complains that the MR must be rebased because a fast-forward merge is not possible. Could you please update your branch? This will trigger a new pipeline and we'll see if it fails again. If so, then I think we need to understand why we are getting those segfaults from various dump tests. Thanks.

    Let me also tag here @rbianchi @jojungge and @boudreau

  • Generally, the CMake configuration of the project should be cleaned up a bit. :thinking: Since right now one can make such mistakes in just too many places. Unfortunately I can't really volunteer to do this. At least not any time soon.

    I'm happy to give you a hand in this (with some guidelines) unless you prefer to do it yourself at some point.

  • added 2 commits

    • 59d53ef5 - 1 commit from branch GeoModelDev:main
    • 04e7196e - Fix GeoModelCppHelpers for header relocatability.

    Compare with previous version

  • Hi @akraszna, thanks for your message. The GeoModelCppHelpers package is temporary. The functions defined there should be moved to the general Helpers package in GeoModelCore. I would have cleaned everything properly before merging that branch, but there was the need for a new tag quickly to move the other tasks forward; as a consequence, proper cleaning was postponed to another MR.

    I can clean it today and remove the temporary package.

    Also, I can also help with the overall CMake configuration if needed.

    Best, --Ric.

    Edited by Riccardo Maria Bianchi
  • Riccardo Maria Bianchi mentioned in merge request !334 (merged)

    mentioned in merge request !334 (merged)

  • GeoModelIO/GeoModelCppHelpers/CMakeLists.txt has been removed from the main branch. I'm closing this MR.

Please register or sign in to reply
Loading