Skip to content
Snippets Groups Projects

Merge all recent work on virtual geometry into main

Merged Joseph Boudreau requested to merge RuiQP into main

Much recent work on virtual surfaces is included in this MR. Three concrete instances of GeoVSurfaceShape (GeoRectSurface, GeoTrapezoidSurface, and GeoAnnulusSurface) are now included. GeoVSurfaceShape is used with GeoVSurface following the pattern of LogVols and PhysVol. A new example plugin called SiliconSystemPlugin demonstrates the use of these classes.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Minor comments to update to inline initialization

  • Noting here that the MR breaks AthSimulation. No merging till this is fixed.

    Not understood why this is happening. DumpGeo before/after MR shows identical SQLite files, the only difference being new tables, but these are still empty since Atlas does not yet make any Virtual Geometry.

  • added 1 commit

    • 80f5a3f2 - Bugfix. This was breaking Athena

    Compare with previous version

  • added 1 commit

    • 3ecb1fd1 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Rui Xue added 1 commit

    added 1 commit

    • 7b58c313 - 1.GeoDiamondSurface is introduced! 2.isOnSurface() method implemented for all virtual surfaces.

    Compare with previous version

  • added 1 commit

    • 9b8292a0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • fc540c34 - Apply 5 suggestion(s) to 3 file(s)

    Compare with previous version

  • added 1 commit

    • 0a2a54af - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading