Refactor, test and reduce code in GeoModelWrite

Extract pure string utilities (or use pre-existing utilities) from GeoModelWrite (joinVectorStrings , getQStringFromOss, getAddressStringFromPointer) into StringUtils.h. Create or move tests. Refactor code using C++20 features.

@rbianchi, this is your realm. Could you please follow up on this MR? Thanks

added 1 commit

• 4e24ba99 - reduction

Compare with previous version

added 2 commits

• 2b31d409 - add comment in test
• a97e1601 - indicate private headers

Compare with previous version

added 1 commit

• 5c893b1c - Move to using StringUtils functions

Compare with previous version

resolved all threads

added 2 commits

• befa8991 - update cmake
• 26dfdd9d - update test of StringUtils to GTest; test new utilities there

Compare with previous version

added 1 commit

• 8e924cc1 - reduce tests as the method is generic

Compare with previous version

added 1 commit

• 4023a2e0 - remove the now-redundant test

Compare with previous version

One pipeline failed here, claiming that C++17 is used:

will see after the final pipeline completes...

There seem to be a few places where C++17 is still referenced:

grep -R "CMAKE_CXX_STANDARD 17" *
FullSimLight/Plugins/TracksPlugin/cmake/configure_cpp_options.cmake:set( CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard used for the build" )
FullSimLight/Plugins/Examples/SensitiveDetectorPlugins/SDPlugin/cmake/configure_cpp_options.cmake:set( CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard used for the build" )
FullSimLight/Plugins/Examples/EventGeneratorPlugins/FSLExamplePrimaryGeneratorPlugin/cmake/configure_cpp_options.cmake:set( CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard used for the build" )
FullSimLight/Plugins/Examples/PhysicsListPlugins/FSLTestPhysListPlugins/cmake/configure_cpp_options.cmake:set( CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard used for the build" )
FullSimLight/Plugins/Examples/MagneticFieldPlugins/UniformMagneticFieldPlugin/cmake/configure_cpp_options.cmake:set( CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard used for the build" )
FullSimLight/Plugins/HitsPlugin/cmake/configure_cpp_options.cmake:set( CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard used for the build" )
cmake/configure_cpp_options.cmake:set( CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard used for the build" )
documentation/docs/fullsimlight/plugins/index.md:set(CMAKE_CXX_STANDARD 17)

In addition (or perhaps, this is the reason), GeoModelAtlas seems to built with C++17.

Note that this all builds fine locally on my Mac.

added 1 commit

• 58ff2871 - trigger rebuild

Compare with previous version

added 1 commit

• 112f6173 - Trigger rebuild

Compare with previous version

added 1 commit

• c1a9ebfe - Sets standard here (built as top level project?)

Compare with previous version

Standard needed to be set in GeoModelTools also.

changed the description

marked this merge request as ready

@rbianchi, are you OK with these changes? I'm happy to merge it

changed the description

resolved all threads