Skip to content
Snippets Groups Projects

GeoModelRead - attempt to clean

Open GeoModelRead - attempt to clean
GeoReadIntrusivePtr into main
Open Johannes Junggeburth requested to merge GeoReadIntrusivePtr into main
  • database queries are no longer class members
  • restructure the way how shapes are built. They're now built on demand instead of all at the same time -> include the boolean shapes in the BuildGeoShape factories
  • Introduce SufaceShape factory mechanism
  • Streamline similar code blocks by templates
  • All GeoObjects are handled by GeoIntrusivePtr.
  • Remove duplicated set of GeoPhysVol & GeoFullPhysVol

Things to improve in the future but that requires a DB schema evolution:

  • GeoTransforms are saved as strings and all 12 numbers of the transform are dumped. First, we can save them as floating point numbers instead of strings and second we can just save the three Euler angles & the translation parameters
  • There are many more tables where information is stored as string. E.g. GeoLogVol, GeoPhysVol, etc. Eventhough only numbers are stored there. Update the schema?
  • The copyNumber mechanism is not employed anywhere. Drop this information from the database?

@sroe, @tsulaia, @boudreau, @rbianchi

Edited by Johannes Junggeburth

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply