Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Commit 4dc6f24a authored 5 years ago by Riccardo Maria Bianchi

Adding back handleLArCustom() to GeoShapeAction.

This is needed to fix the Athena master build. When removing the LArCustomShape from GeoModelIO, in fact, all occurences of LArCustomShape were removed from GeoModelKernel as well; but Athena still use them, in particular the handleLArCustom() method of the GeoShapeAction class.

For details:

- atlas/athena!31618 (comment 3321141)
- 62142525

parent 428b93b1

No related branches found

No related tags found

No related merge requests found

Pipeline #1525094 passed 5 years ago

Hide whitespace changes

Inline Side-by-side

Showing with 13 additions and 6 deletions

Attila Krasznahorkay @akraszna · 5 years ago

Contributor

Please no! Ric, don't revert the code!

Please no! Ric, don't revert the code!
Attila Krasznahorkay @akraszna · 5 years ago

Contributor

Hopefully e-mails are enabled... But just in case, cc-ing @rbianchi and @boudreau.

Hopefully e-mails are enabled... But just in case, cc-ing @rbianchi and @boudreau.
Riccardo Maria Bianchi @rbianchi · 5 years ago

Author Owner

Yes, since it's not needed anymore to quickly fix the Athena build, I'm reverting this commit and deleting the tag.

Yes, since it's not needed anymore to quickly fix the Athena build, I'm reverting this commit and deleting the tag.
Riccardo Maria Bianchi @rbianchi
mentioned in commit 7e770fd3
· 5 years ago

mentioned in commit 7e770fd3

mentioned in commit 7e770fd35cd0b39716ea8302063f979dded399d2

Toggle commit list
Riccardo Maria Bianchi @rbianchi
mentioned in merge request !7 (merged)
· 5 years ago

mentioned in merge request !7 (merged)

mentioned in merge request !7

Toggle commit list
Riccardo Maria Bianchi @rbianchi
mentioned in commit 1328541b
· 5 years ago

mentioned in commit 1328541b

mentioned in commit 1328541baf76d043b2c5aa7e0cccd6e8b8cf02b3

Toggle commit list

Please register or to comment