Skip to content

[SIGMON-179] Reading RQ U_DIODE_RQx signals

Aleksandra Mnich requested to merge SIGMON-179_reading_u_diode_rqx into dev

Context

What was done

  • DiodeLeadResistanceQuery refactored, method for obtaining metadata for voltage queries extracted (_get_u_query_metadata)
  • DiodeLeadResistanceRqQuery created with its own _get_u_query_metadata method that implements 'correct reading of U_DIODE_RQx signals'

TODO

QA

Review objectives

  • assessment of code functionality
  • assessment of code quality
  • identifying potential refactorings / logic common to other projects
  • knowledge sharing
  • getting help to understand a piece of code
Edited by Aleksandra Mnich

Merge request reports