[SIGMON-302] new AN_RB_FPA
Context
- task: https://its.cern.ch/jira/browse/SIGMON-302 (but also https://its.cern.ch/jira/browse/SIGMON-278)
-
lhc-sm-hwc
MR: lhc-sm-hwc!84 (merged)
What was done
- the
result_table
for RBs and RQs is now populated only if both iQPS and nQPS are present (otherwise there is a single row created) -
papremill
added to theswan-nxcals-spark3-requirements.txt
(so it will bring the same version oftraitlets
on SWAN as we have in the GitLabCI/Jenkins) - for
600A
circuits the property name has changed to theI_MEAS_CPCNT
(in %%) whereas the variable name stayed<>:I_MEAS_PCNT
. In the metadata we havedevice
key for this system, henceDevicePropertyQuery
is used and theI_MEAS_CPCNT
is needed
TODO
- Analysis and Query classes needs to be refactored so we can reduce a code duplication
QA
- http://sonar.cern.ch/project/issues?branch=SIGMON-302_new_AN_RB_FPA&id=lhc-sm-api&resolved=false
- notebooks passed: https://gitlab.cern.ch/LHCData/lhc-sm-hwc/-/jobs/19023167
Review objectives
- assessment of code functionality
- assessment of code quality
- identifying potential refactorings / logic common to other projects
- knowledge sharing
Edited by Aleksandra Mnich
Merge request reports
Activity
Filter activity
Please register or sign in to reply