Skip to content

[SIGMON-302] new AN_RB_FPA

Aleksandra Mnich requested to merge SIGMON-302_new_AN_RB_FPA into dev

Context

What was done

  • the result_table for RBs and RQs is now populated only if both iQPS and nQPS are present (otherwise there is a single row created)
  • papremill added to the swan-nxcals-spark3-requirements.txt (so it will bring the same version of traitlets on SWAN as we have in the GitLabCI/Jenkins)
  • for 600A circuits the property name has changed to the I_MEAS_CPCNT (in %%) whereas the variable name stayed <>:I_MEAS_PCNT. In the metadata we have device key for this system, hence DevicePropertyQuery is used and the I_MEAS_CPCNT is needed

TODO

  • Analysis and Query classes needs to be refactored so we can reduce a code duplication

QA

Review objectives

  • assessment of code functionality
  • assessment of code quality
  • identifying potential refactorings / logic common to other projects
  • knowledge sharing
Edited by Aleksandra Mnich

Merge request reports