Skip to content

[SIGMON-309] SignalMetadata

Context

What was done

  • default behaviour of SignalMetadata changed: if no timestamp is provided, the most recent metadata is returned
  • SignalMetadata partially refactored: unused methods removed, module renamed
  • tests improved

To review

  • signal_metadata.py
  • test_signal_metadata.py
  • check if timestamp argument is passed to the signal_metadata's functions (if possible)

TODO

  • ? (it would be nice to remove jsons one day)

QA

Review objectives

  • assessment of code functionality
  • assessment of code quality
  • identifying potential refactorings / logic common to other projects
  • knowledge sharing
Edited by Aleksandra Mnich

Merge request reports

Loading