[SIGMON-306] pylint ack in PcAnalysis
Context
- Not to be depressed by the lack of progress on https://its.cern.ch/jira/browse/SIGMON-306 I acknowledged the pylint complaints (those which do not change method signatures and package names)
What was done
- f strings used, common code extracted to private functions
TODO
- solve the mystery of the missing print output
QA
- sonar: http://sonar/project/issues?branch=SIGMON-306_no_print_output&id=lhc-sm-api&resolved=false
- notebooks passed:
Review objectives
- ? assessment of code functionality
- ? assessment of code quality
- ? identifying potential refactorings / logic common to other projects
- ? knowledge sharing
- ? getting help to understand a piece of code