[SIGMON-299] Backwards compatible QueryBuilder
Context
- Main goal of the task was to reimplement
QueryBuilder
usinglhcsmapi.api.query
to validate the latter - task: https://its.cern.ch/jira/browse/SIGMON-299
-
lhc-sm-hwc
MR: lhc-sm-hwc!103 (merged)
What was done
- old builders from
pyedsl
removed - new (simplified) QueryBuilder implemented in
lhcsmapi.api.query_builder
- supports only those 'paths' which are actually used - hacks to support the old
QueryBuilder
removed fromsignal_metadata
- small refactoring of
query.py
(+ outputs unified but this is continued by SIGMON-341) - signal is sanitized: (0-valued, duplicated or non-monotonic indices are being removed now)
-
query_raw_pm_data
that returns aDict
with the PM payload was written -
PcQuery#query_pc_pm_events
were rewritten usingquery_raw_pm_data
TODO
- integrate with https://its.cern.ch/jira/browse/SIGMON-341
QA
- sonar: http://sonar.cern.ch/dashboard?branch=SIGMON-299_backwards_compatible_query_builder&id=lhc-sm-api
- code was unit tested
- notebooks were adapted and are passing:
Review objectives
- ? assessment of code functionality
- ? assessment of code quality
- ? identifying potential refactorings / logic common to other projects
- ? knowledge sharing
- ? getting help to understand a piece of code
Edited by Jonas Barth