Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • lhc-sm-api lhc-sm-api
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCData
  • lhc-sm-apilhc-sm-api
  • Merge requests
  • !187

[SIGMON-371] Validation comments ack

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Aleksandra Mnich requested to merge SIGMON-371_validation_ack into dev Jun 22, 2022
  • Overview 0
  • Commits 8
  • Pipelines 3
  • Changes 19

Context

  • task: https://its.cern.ch/jira/browse/SIGMON-371
  • lhc-sm-hwc mr: lhc-sm-hwc!117 (diffs)

What was done

  • presentation: https://docs.google.com/presentation/d/1aM26oJE8WjbqqTlBvVZ-QTetXAIwR5BNLUgRTsUVOco/edit#slide=id.gc6f73a04f_0_5

TODO

  • ?

QA

  • sonar: http://sonar/dashboard?branch=SIGMON-371_validation_ack&id=lhc-sm-api
  • no new tests written

Review objectives

  • ? assessment of code functionality
  • ? assessment of code quality
  • ? identifying potential refactorings / logic common to other projects
  • ? knowledge sharing
  • ? getting help to understand a piece of code
Edited Jun 22, 2022 by Aleksandra Mnich
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: SIGMON-371_validation_ack