Alexandra Murariu requested to merge SIGMON-333_mypy_fix_in_lhc-sm-api into dev Mar 07, 2024

Context

Project(s) README(s) link(s)
Story reminder: SIGMON-333
Task details: During the review of the !158 (merged) we also noticed that the command we are executing in the type_checking stage is not reporting all the exceptions - investigate.

Acceptance criteria:

The lhcsmapi.api methods passes mypy checks
The pipeline is now greed
The pipeline is red if mypy is not passing

What was done

changed the type checking command to look only at the api folder
removed the permission to succeed on failure

TODO

QA

code was not unit tested, because this is a pipeline code
acceptance tests were not written, because this is a pipeline code

Review objectives

? assessment of code functionality
? assessment of code quality
? identifying potential refactorings / logic common to other projects
? knowledge sharing
? getting help to understand a piece of code

Closes SIGMON-333