implement get_generic_circuit_type
4 unresolved threads
4 unresolved threads
See LHCData/lhc-sm-analysis/lhc-sm-qh!56 (comment 8421337). Thinking of it, this is quite a long overdue.
Merge request reports
Activity
Filter activity
requested review from @agchmiel
assigned to @smazenou
requested review from @amurariu
requested review from @abarba
611 651 mask_magnets_with_nan = (magnet_to_qps_crate_df["Circuit"] == circuit_name) & ( 612 652 magnet_to_qps_crate_df["Crate U_DIODE_RQx"].isna() 613 653 ) 614 return magnet_to_qps_crate_df[mask_magnets_with_nan]["Magnet"].values 654 return magnet_to_qps_crate_df[mask_magnets_with_nan]["Magnet"].values.tolist() 736 776 ValueError: If the circuit name is not present in the metadata 737 777 """ 738 778 try: 739 circuit_type = get_circuit_type_for_circuit_name(circuit_name) 779 circuit_type = get_generic_circuit_type_for_circuit_name(circuit_name) 740 780 except KeyError as e: 741 781 raise ValueError(f"Circuit name {circuit_name} not present in the metadata.") from e 742 782 1437 1437 assert "'Circuit name ABC does not map to internal metadata.'" == str(exception.value) 1438 1438 1439 1439 1440 @pytest.mark.parametrize( 1441 ("circuit_name", "expected_circuit_type"), 1442 [ 1443 ("RCBH11.L1B2", signal_metadata.GenericCircuitType.A60), changed this line in version 3 of the diff
mentioned in commit 966f101f
Please register or sign in to reply