Sigmon 53 refactoring qh module
Context
- Project README link: https://gitlab.cern.ch/LHCData/lhc-sm-api/-/blob/sigmon-53_refactoring_qh_module/README.md
- Story reminder: https://its.cern.ch/jira/browse/SIGMON-53
- Task details https://its.cern.ch/jira/browse/SIGMON-36
https://its.cern.ch/jira/browse/SIGMON-90
https://its.cern.ch/jira/browse/SIGMON-91
What was done
- keypoints of the implementation / code changes: --> Split the QuenchHeaterAnalysis file into 2 files QuenchHeaterVoltageAnalysis and QuenHeaterVoltageCurrentAnalysis.
--> Many CSV files appears in the changes
list, but they have no impact in the core changes, and are not part on the review, mainly reformatting files.
- why was this solution preferred over another? --> This method has been choosen to avoid code duplication and bring a more maintenable code structure.
- ? what could be improved on?
TODO
- Anything still to be done?
QA
- code was unit tested
Review objectives
- assessment of code functionality
- assessment of code quality
- identifying potential refactorings / logic common to other projects
- knowledge sharing
Edited by Thibaud Marie Eric Buffet