[SIGMON-116] Check nQPS sources
Context
- ticket: https://its.cern.ch/jira/browse/SIGMON-116
- The goal was to add a simple check that all nQPS PMs buffers were triggered and transmitted.
What was done
- method which warns if any of PM sources wasn't found, added to
DiodeLeadResistanceQuery
(it's executed if the appropriate flag offind_source_timestamp_nqps
method is set) - additionally tiny fix done in
HwcSearchModuleMediator
- exception caused by empty DataFrame in
[Rb/Rq]Query#create_report_analysis_template
fixed
TODO
- (?) mp3 experts will judge
QA
- sonar: http://sonar.cern.ch/project/issues?branch=SIGMON-116_check_nQPS_sources&id=lhc-sm-api&resolved=false
- code was unit tested
Review objectives
- assessment of code functionality
- assessment of code quality
- identifying potential refactorings / logic common to other projects
- knowledge sharing
Edited by Aleksandra Mnich