Skip to content

Sigmon 152 ipq query fails

Alessio Cosenza requested to merge SIGMON-152_ipq_query_fails into dev

Context

What was done

  • ipq_query.query_pc_pm_with_source now checks for empty timestamp
  • Added tests for ipq_query.query_pc_pm_with_source

Review objectives

  • assessment of code functionality
  • assessment of code quality
  • identifying potential refactorings / logic common to other projects
  • knowledge sharing
  • should we export functions like check_warnings and check_empty_dfs to another module and use them in all the tests?
Edited by Alessio Cosenza

Merge request reports