Alessio Cosenza requested to merge SIGMON-153_FgcPmSearchModuleMediator_KeyError into dev Aug 24, 2021

Context

https://its.cern.ch/jira/browse/SIGMON-153

What was done

added check for source_timestamp_df emptiness in both ItFgcPmFindButtonBaseModule and IpdFgcPmFindButtonModule
added unit tests for query_pm_convert_pc_to_circuit_name

QA

template link to sonar issues: http://sonar.cern.ch/project/issues?branch=SIGMON-153_FgcPmSearchModuleMediator_KeyError&id=lhc-sm-api&resolved=false
code was unit tested

Review objectives

? assessment of code functionality
? assessment of code quality
? identifying potential refactorings / logic common to other projects
? knowledge sharing

Edited Aug 25, 2021 by Alessio Cosenza