Skip to content

[SIGMON-467] ack Zinurs feedback

Aleksandra Mnich requested to merge SIGMON-467_ack_zinurs_feedback into dev

Context

  • Project(s) README(s) link(s)
  • Story reminder
  • Task details
  • ? other related reviews
  • ? are superseded reviews closed?

What was done

  • the different functions used to detect the start of the quench for 600A FPA notebooks
  • a summary cell added to QHDA notebooks
  • RB_FPA:
    • plot all U_DIODE_RB PM signals as they are
    • iQPS threshold changed to 100mV
  • new quench event used for the test of AN_600A_RCBXHV_FPA
  • references regenerated

TODO

  • ?

Review objectives

  • ? assessment of code functionality
  • ? assessment of code quality
  • ? identifying potential refactorings / logic common to other projects
  • ? knowledge sharing
  • ? getting help to understand a piece of code
Edited by Aleksandra Mnich

Merge request reports