SIGMON-128: - Change outdated rb_analysis method and replace with a rbAnalysis
-
Project README: https://gitlab.cern.ch/LHCData/lhc-sm-api
-
Story reminder:
Plots for Quench Heater Discharge Analysis on FPA and HWC are differents https://its.cern.ch/jira/browse/SIGMON-128 -
Task details:
-
Understand why the plots on FPA are not correct and not aligned with the HWC.
What was done
- keypoints of the implementation
- Update on the Plotting method on the QuenchHeaterVoltageCurrentAnalysis.py for plotting the analysis signals.
- Update the evaluation of the indexes of the current and voltage (same for references.)
- What is not done
- During the investigation of the task, we found out that the deployments on EOS are not removing the old
classes
and not replacing them correctly. Which leads to some inconsistencies. This will be tackle after the end of the HWC.
Review objectives
- assessment of code functionality
- assessment of code quality
- identifying potential refactorings / logic common to other projects
- knowledge sharing
Edited by Thibaud Marie Eric Buffet