[SIGMON-201] test notebooks reports
Context
- task: https://its.cern.ch/jira/browse/SIGMON-201
-
lhc-sm-notebook
MR: lhc-sm-notebook!13 (merged)
What was done
-
Notebooks' last cell refactored:
path_to_notebook
,report_destination_path_template
andreport_filename_template
variables extracted and moved to the top (just below the imports) so they could be overwritten by the injected parameters: -
The content of the HTML report and the CSV files produced by the notebook is asserted in the tests. CSVs are compared with the reference files as they are (
==
); HTMLs are preprocessed similarly to the resulting notebooks. -
magic functions in
nQPS_Viewer.ipynb
fixed
TODO
- documentation https://its.cern.ch/jira/browse/SIGMON-199
QA
- code was not unit tested, because it's
lhc-sm-hwc
- notebooks passed: https://gitlab.cern.ch/LHCData/lhc-sm-hwc/-/jobs/17660303
Review objectives
- assessment of code functionality
- assessment of code quality
- identifying potential refactorings / logic common to other projects
- knowledge sharing
Edited by Aleksandra Mnich