Dev
Context
- SIGMON 113 (https://its.cern.ch/jira/browse/SIGMON-113)
- In brief: update notebook RQ_PLI2.f1 from RQ_FPA notebook
What was done
- Analysis, Cell 8.3: just copy/paste whole cell (code)
- Query, Cell 2: just copy/paste the part #iQPS (few lines of code)
TODO
- ? Anything still to be done?
QA
- template link to sonar issues:http://sonar/component_issues/index?id=_GROUP_%3A_ARTIFACT_#resolved%3Dfalse%7Cauthors%3D_PAIR1_%2C_PAIR2_
- code was unit tested | was not unit tested, because...
- acceptance tests were written | not written, because...
Review objectives
- ? assessment of code functionality
- ? assessment of code quality
- ? identifying potential refactorings / logic common to other projects
- ? knowledge sharing
- ? getting help to understand a piece of code
Edited by Thibaud Marie Eric Buffet