Per-part specification for SDC added, fixed factors
Drafted per-part feature, fixed factor overriding, see details in merge request 345 discussion.
Below is the copy of MR details by Renat from !345 (merged) discussion:
With !347 (merged) I have introduced a small addition to MSADC/calo calibration format. First, I noticed many places were same calibration entries were specified repeatedly, just to fill the whole calorimeter with couple of values, like here, so I think it will be useful to have an ability to specify some values to the whole part (but this feature is not completely implemented as I am not sure it is really needed). Secondly it is now possible to specify this factors as columns. Per se this feature is probably useless, however SDC takes care only on the CSV-like blocks and validity periods are not applied to the metadata (would be huge over-complication). So what I propose with this merge request is to override factors as following:
# this is our usual stuff:
runs=6035-8395
factor.ECAL0=0.05 * 100. * 0.684
factor.ECAL1=0.95 * 100. * 0.684
columns=name,x,y,amp,amp_err,peakpos,peakpos_err,sigmaL,sigmaL_err,sigmaR,sigmaR_err,chi2ndf,ledref
ECAL0 0 2 300.3 1.513 1328 10.6 526.8 10.7 635.6 12.26 0.9588 1733.8
# ... whatever
# this block will override factors, but only for cells specified
columns=name,x,y,peakpos,ledref
runs=6723-6824
factor.ECAL0 = 1000
ECAL0 2 3 1. 1370.
ECAL1 2 3 2376. 348.96
# this also will work, but factors will change only for certain cells
runs=6825-6840
factor.ECAL0 = 1000 * 2
ECAL0 2 3 1. 1309.
ECAL1 2 3 2467. 339.60
# This is new -- it is a "per-part" specification that affects ALL the
# cells with previously specified calibrations.
runs=6723-6724
columns=name,factor
ECAL0 123
ECAL1 321
# Another "per-part" specification that affects ALL the
# cells with previously specified calibrations.
runs=6725-6729
columns=name,factor
ECAL0 456Merge request also introduces a fix to overriding behavior: currently factors do not change within a single file because of missed block in merging procedure. !347 (merged) fixes this and also provides mechanism to avoid this kind of mistakes in a future.