Skip to content

Resolve "Library for reentant code"

Renat Dusaev requested to merge 49-mm-lib-simpler into master

Closes #49 (closed) (mm clustering to a library)

This MR moves MM clustering code to a library. As was discussed, this version just moves code, no dedicated effort made to preserve git history. Design changes are deliberately minimal and any comments are welcome from ETH(Z) (I suppose, @bbantoob would like to have a look -- or just slap "approve" as you've seen all these already couple of times).

Doubts:

  • conddbpath(), na64session(), FindApvPedestalFile() from conddb.h were also moved to mm.cc since these functions are used in calibration loading code
  • DetGeo seems to intend to become a kinda generalized geometry description for the setup, albeit is used tightly only with MMs
  • calibration-related MM-specific classes (time_parameters, time_errors, MM_plane_timing, etc) were also moved

To me still, wiser decision would be to decouple 1) calib. loading routines, 2) calibration data classes and 3) detector entities, but as was discussed in #49 (closed) we stick to "more compact" design.

Merge request reports