Update jet criteria

Created by: aperloff

Update JetID Update makeGoodJets to be cone size aware (i.e. minimum pT for AK8 jets is now 170).

also in the future please update branches by rebasing instead of merging

Created by: aperloff

Alright, the use of TMEras has been changed per your specifications. Also, I shall rebase in the future.

Created by: aperloff

Do you mean on line 37 and 56? Put a line break after "GoodJets,"?

yes

Created by: aperloff

Which indentation style do you like more?

    TMeras.TM2016.toModify(GoodJets,
                           TagMode                   = cms.bool(True),
                           JetTag                    = JetTag,
                           maxJetEta                 = cms.double(5.0),
                           minNconstituents          = cms.int32(1),
                           minNneutralsHF            = cms.int32(10),
                           minNcharged               = cms.int32(0),
                           maxNeutralFraction        = cms.double(0.99),
                           maxPhotonFraction         = cms.double(0.99),
                           maxPhotonFractionHF       = cms.double(0.90),
                           minChargedFraction        = cms.double(0),
                           maxChargedEMFraction      = cms.double(0.99),
                           jetPtFilter               = cms.double(30),
                           ExcludeLepIsoTrackPhotons = cms.bool(True),
                           JetConeSize               = cms.double(jetConeSize),
                           SkipTag                   = SkipTag,
                           SaveAllJetsId             = True,
                           SaveAllJetsPt             = False, # exclude low pt jets from good collection
                           )
    TMeras.TM2017.toModify(GoodJets,
                                    TagMode                   = cms.bool(True),
                                    JetTag                    = JetTag,
                                    maxJetEta                 = cms.double(5.0),
                                    minNconstituents          = cms.int32(1),
                                    minNneutralsHE            = cms.int32(2),
                                    minNneutralsHF            = cms.int32(10),
                                    minNcharged               = cms.int32(0),
                                    maxNeutralFraction        = cms.double(0.90),
                                    maxNeutralFractionHE      = cms.double(1.00), #Turned off as not needed for the tight WP
                                    minNeutralFractionHF      = cms.double(0.02),
                                    maxPhotonFraction         = cms.double(0.90),
                                    minPhotonFractionHE       = cms.double(0.02),
                                    maxPhotonFractionHE       = cms.double(0.99),
                                    maxPhotonFractionHF       = cms.double(0.90),
                                    minChargedFraction        = cms.double(0.00),
                                    maxChargedEMFraction      = cms.double(1.00), #Turned off as not needed for the tight WP
                                    jetPtFilter               = cms.double(170 if jetConeSize==0.8 else 30),
                                    ExcludeLepIsoTrackPhotons = cms.bool(True),
                                    JetConeSize               = cms.double(jetConeSize),
                                    SkipTag                   = SkipTag,
                                    SaveAllJetsId             = True,
                                    SaveAllJetsPt             = False, # exclude low pt jets from good collection
                          )

neither

    TMeras.TM2016.toModify(GoodJets,
        TagMode                   = cms.bool(True),
    )

Created by: aperloff

Style changed.

@aperloff I realized we need to fix this setting as well: https://github.com/TreeMaker/TreeMaker/blob/d857e38486b3a0daa82c2acf655c4c059ed250ce/TreeMaker/python/makeJetVars.py#L80

Created by: aperloff

So it should be 20 for 2016, but should it stay the same for 2017? Should it also filter AK8 jets at 170GeV? Once I know this I'll put in a new PR.

Let's keep it at 20 for 2017 as well, for now. This was needed because of some silly fastsim filter, but I have no idea if it will still be needed in 2017 or not. (There aren't any 2017 fastsim samples yet...) Yes, we should also put the 170 cut on AK8 jets for fastsim.