Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • T TreeMaker
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • TreeMaker
  • TreeMaker
  • Merge requests
  • !490

[Run2_2017] Add a new Docker image for ServiceX

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexx Perloff requested to merge github/fork/aperloff/Run2_2017_Docker into Run2_2017 Apr 03, 2020
  • Overview 10
  • Commits 12
  • Pipelines 0
  • Changes 7

Created by: aperloff

Add the automatic creation of a new Docker image for ServiceX. This creation will take place after the base image for TreeMaker and simultaneous to the integration test. The reason this image is needed is to add some customization to the python packages and environment variables.

In doing this work, several updated were made to the GitHub actions workflow.

  1. Publishing is turned off for all users except 'TreeMaker'. While this isn't totally secure, it prevents innocent users from accidentally overwriting the images if they happen to have the DockerHub secrets.
  2. The integration-test and service-x workflows won't run if the user isn't 'TreeMaker'. As the image won't be updated unless the user is merging in the Run2_2017 branch after a PR and the users account can't publish the resulting images, it doesn't make sense to go through the effort for them to run a second , but unpublished, integration test.

Because of the changes mentioned above, I was unable to test to ServiceX workflow in it's entirety. I was able to test that if one uses the treemaker/treemaker:Runw_2017-latest image, that the .github/ServiceX/scripts/setup.sh works. The only part that is untested is the .github/ServiceX/scripts/setup-root.sh part.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/aperloff/Run2_2017_Docker