Skip to content

Improve torus surfmodel

Severin Diederichs requested to merge improve_torus_surfmodel into surface_model

This MR improves the torus implementation in a few ways:

  • the bounding tube was fixed and now also has an inner cylinder
  • an error in the frame check was fixed
  • the calculation in the torus model are rescaled to the torus radius, this ensures that the coefficients are usually well behaved (on the order of 1). Now, they only fail in very rare cancellation cases (where they also fail for root and the solid model).

Merge request reports