Skip to content

[surface model] Fix ring ring embeddedness

Severin Diederichs requested to merge fix_ring_ring_embeddedness into surface_model

Previously, the embedded flag for rings within rings was not always correct, since rings with a phi cut and a rotation just in the XY plane were considered as a general case. By adding a check for just xy rotated ring masks, the flag is set correctly for many cases in CMS.

Note that similar things might apply for the ZPhi Mask.

Side note: this MR also changes an issue in the overlap detection, which should only rely on exiting surface information, not on entering one. However, this then ruins the printouts for exited common surfaces, so this should be done differently. Therefore, this remains as a draft.

Edited by Severin Diederichs

Merge request reports